Bump version to 1.4.3 for PyPI release#689
Open
SaintFresh wants to merge 1 commit intoXPixelGroup:masterfrom
Open
Bump version to 1.4.3 for PyPI release#689SaintFresh wants to merge 1 commit intoXPixelGroup:masterfrom
SaintFresh wants to merge 1 commit intoXPixelGroup:masterfrom
Conversation
Summary: This pull request bumps the `basicsr` version to 1.4.3 to trigger a new release on PyPI. The new release will include an important fix for a `torchvision` import error that affects users relying on the latest PyPI version. Issue: The current version of `basicsr` (1.4.2) on PyPI is missing a fix for a `ModuleNotFoundError` related to importing the `rgb_to_grayscale` function from `torchvision`. This fix is already present in the main branch of the repository, but it hasn't been released to PyPI yet. (e.g. GFPGAN / ESRGAN in their colab notebook) Solution: By bumping the version number in the `VERSION` file, this pull request will trigger a new release on PyPI, making the fix available to all users who install `basicsr` through `pip`. Testing: I have confirmed that this fix works correctly in my local environment.
|
Who can review those checks to approve this PR @SaintFresh ?? It would be very usefull to have this new version available 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request bumps the
basicsrversion to 1.4.3 to trigger a new release on PyPI. The new release will include an important fix for atorchvisionimport error that affects users relying on the latest PyPI version.Issue:
The current version of
basicsr(1.4.2) on PyPI is missing a fix for aModuleNotFoundErrorrelated to importing thergb_to_grayscalefunction fromtorchvision. This fix is already present in the main branch of the repository, but it hasn't been released to PyPI yet. (e.g. GFPGAN / ESRGAN in their colab notebook)Solution:
By bumping the version number in the
VERSIONfile, this pull request will trigger a new release on PyPI, making the fix available to all users who installbasicsrthroughpip.Testing:
I have confirmed that this fix works correctly in my local environment.